-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry pick - Chef CD, sample apps, esp32 rpc fix, to interop branch #19979
Cherry pick - Chef CD, sample apps, esp32 rpc fix, to interop branch #19979
Conversation
* Chef - Extended Pigweed RPC support (project-chip#17781) * Build flash_script package for ESP32 Change-Id: I4e0375c9b9837b3b9f8a3d2570635536e7e34e42 Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1419520 Reviewed-by: Doug Ferraz <[email protected]> * new: Wifi and Descriptor clusters on ESP32 Change-Id: I37b61425a55d8210c2286becce47917fddf54a3f Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1418359 Reviewed-by: Rob Oliver <[email protected]> Reviewed-by: Kevin Cheung <[email protected]> Reviewed-by: Jerry Lee <[email protected]> * new: added stub file. Included callbacks for successful operation of lock/unlock commands Change-Id: I9f4d601feb3b043d3c6689775bcaf40a8c5564d2 Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1420959 Reviewed-by: Michael Spang <[email protected]> Reviewed-by: Jerry Lee <[email protected]> * Enable PW RPC server on chef-built virtual device app Change-Id: I878955e9df26e893c136650654019a8fa14e2a8b Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1417979 Reviewed-by: Doug Ferraz <[email protected]> * cosmetic change Change-Id: Ia2063a395a8d3f16965356d4a76b0d9df0834e57 * changes to linux pigweed dependencies. Still has issues building Pigweed Change-Id: I2be4e81f6c2e14112e31a0803813ef56d012b206 * Fix nrfconnect compilation errors (project-chip#17713) * Fix nrfconnect compilation errors * Chef: fix arguments for clean build * Build flash_script package for ESP32 Change-Id: I4e0375c9b9837b3b9f8a3d2570635536e7e34e42 Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1419520 Reviewed-by: Doug Ferraz <[email protected]> * new: Wifi and Descriptor clusters on ESP32 Change-Id: I37b61425a55d8210c2286becce47917fddf54a3f Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1418359 Reviewed-by: Rob Oliver <[email protected]> Reviewed-by: Kevin Cheung <[email protected]> Reviewed-by: Jerry Lee <[email protected]> * new: added stub file. Included callbacks for successful operation of lock/unlock commands Change-Id: I9f4d601feb3b043d3c6689775bcaf40a8c5564d2 Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1420959 Reviewed-by: Michael Spang <[email protected]> Reviewed-by: Jerry Lee <[email protected]> * Enable PW RPC server on chef-built virtual device app Change-Id: I878955e9df26e893c136650654019a8fa14e2a8b Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1417979 Reviewed-by: Doug Ferraz <[email protected]> * cosmetic change Change-Id: Ia2063a395a8d3f16965356d4a76b0d9df0834e57 * changes to linux pigweed dependencies. Still has issues building Pigweed Change-Id: I2be4e81f6c2e14112e31a0803813ef56d012b206 * Restyled by gn * Restyled by autopep8 * Restyled by gn Co-authored-by: Sebastian Mauer <[email protected]> Co-authored-by: MT Tsai <[email protected]> Co-authored-by: vinitg1 <[email protected]> Co-authored-by: Restyled.io <[email protected]> Change-Id: I827aa39ea41b8084d6fdca202e5a87e0f29cb4f3 * fix: added initialization to platform wifi network commissioning instance (project-chip#17983) Change-Id: I03b6b523d4c4557ab6cc432216e48b6d6b2b6964 * Chef - Revert changes on lighting-app that separate wifi and thread Co-authored-by: Douglas Rocha Ferraz <[email protected]> Co-authored-by: Sebastian Mauer <[email protected]> Co-authored-by: MT Tsai <[email protected]> Co-authored-by: vinitg1 <[email protected]> Co-authored-by: Restyled.io <[email protected]>
* Chef - Remove redundant hash_string in sample_app_util rename func * Chef - Add debugg output on exception to stateful_shell * Chef - Add choices for device arg * Chef - Add 13 sample apps
…it_id> on linux platform (project-chip#19710)" (project-chip#19786) This reverts commit 8da6fc8.
…al length greater equal to 64 bytes. (project-chip#19788) Make the filling of software version string with <branch>:<commit_id> as an option. The new option for it is '-a' or '--automated_test_stamp'.
…ting platforms (project-chip#19478) * Squashed commit of the following: commit b5d5920 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 18:17:34 2022 +0000 [no ci] comment commit 7c5fb08 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 18:15:37 2022 +0000 [no ci] Make border nice commit d67a7bc Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 18:09:29 2022 +0000 [no ci] restyle commit 5783829 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 17:48:39 2022 +0000 Add error handling to build all commit 083b072 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 17:15:33 2022 +0000 [no ci] update build image version commit 48805a8 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 08:20:49 2022 +0000 [no ci] minor commit 3cae95c Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 08:15:22 2022 +0000 [no ci] Minor commit df929b2 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 07:37:49 2022 +0000 Minor commit 759ddb0 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 07:28:36 2022 +0000 Minor commit d9ca2a6 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 07:22:03 2022 +0000 Style commit dbb9b30 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 06:50:11 2022 +0000 Style commit 3daff46 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 02:58:43 2022 +0000 nrf bundle commit 7d38eb4 Author: Austin Bozowski <[email protected]> Date: Wed Jun 8 16:34:57 2022 +0000 Linux bundle commit fd5689e Author: Austin Bozowski <[email protected]> Date: Wed Jun 8 09:08:42 2022 +0000 Make esp32 generic commit 1af3a2e Author: Austin Bozowski <[email protected]> Date: Tue Jun 7 08:35:52 2022 +0000 Missed comment commit 5f7c41c Author: Austin Bozowski <[email protected]> Date: Tue Jun 7 08:32:07 2022 +0000 Example bundle function * Bundle .matter, metadata & ensure .matter commit * Add partial check for .matter regen * Restyle and spelling * Address comments * Remove reflection * Generate zzz, .MATTERMD5 should go away in future * Temp del workflows * Remove chef exclusion from regen * Make regen all put chef exs in individual dirs * Remove validate zzz * Remove unused code from chef, change use_zzz * Skip util test files in gen all * Commit chef in root zzz * Delete chef zzz * Clean chef .matter files * Add post build for chef * Change .matter bundle rc to oot zzz * Generated files * Restore workflows * Change open to with * Restyle
…ct-chip#19876) * Chef - Fix broken esp32 RPC build caused by project-chip#18621 * Chef - Fix esp32 RPC build issue caused by pigweed update
…hip#18667) * Make Scenes name support dependent on FeatureMap attribute * Fix CI
I've never seen an issue on the restyled job like this. Anyone familiar with this? |
It seems zap-regen, likely your local clang-format is diffferent than what CI is using. I suggest to run the restyle-diff script. If unable, ping me and I will run it for you. It also seems we need to CP a git fix for Infineon - we can do that separately. |
I'm working through some of the issues on my personal repo (cpagravel#5). I'll update when I have worked out all of the issues. Currently stuck on the zap_regen failure. Something is causing Zap to have different formatting in the regen job compared to locally. Update: Zap regen failure is due to me adding a regenerated file that shouldn't have been added. Specifically I added: |
c520e19
to
012f01d
Compare
Please do not merge, there is an issue with the |
012f01d
to
d154488
Compare
This has been resolved. Everything should be in order now. |
PR #19979: Size comparison from e831046 to d154488 Increases above 0.2%:
Increases (11 builds for efr32, esp32, linux, mbed, nrfconnect, p6)
Decreases (1 build for esp32)
Full report (29 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
…roject-chip#19979) * Pigweed: Update to 67bc89cdda8c (project-chip#19560) * Fix esp32 wifi and add RPC support on linux (project-chip#19260) * Chef - Extended Pigweed RPC support (project-chip#17781) * Build flash_script package for ESP32 Change-Id: I4e0375c9b9837b3b9f8a3d2570635536e7e34e42 Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1419520 Reviewed-by: Doug Ferraz <[email protected]> * new: Wifi and Descriptor clusters on ESP32 Change-Id: I37b61425a55d8210c2286becce47917fddf54a3f Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1418359 Reviewed-by: Rob Oliver <[email protected]> Reviewed-by: Kevin Cheung <[email protected]> Reviewed-by: Jerry Lee <[email protected]> * new: added stub file. Included callbacks for successful operation of lock/unlock commands Change-Id: I9f4d601feb3b043d3c6689775bcaf40a8c5564d2 Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1420959 Reviewed-by: Michael Spang <[email protected]> Reviewed-by: Jerry Lee <[email protected]> * Enable PW RPC server on chef-built virtual device app Change-Id: I878955e9df26e893c136650654019a8fa14e2a8b Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1417979 Reviewed-by: Doug Ferraz <[email protected]> * cosmetic change Change-Id: Ia2063a395a8d3f16965356d4a76b0d9df0834e57 * changes to linux pigweed dependencies. Still has issues building Pigweed Change-Id: I2be4e81f6c2e14112e31a0803813ef56d012b206 * Fix nrfconnect compilation errors (project-chip#17713) * Fix nrfconnect compilation errors * Chef: fix arguments for clean build * Build flash_script package for ESP32 Change-Id: I4e0375c9b9837b3b9f8a3d2570635536e7e34e42 Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1419520 Reviewed-by: Doug Ferraz <[email protected]> * new: Wifi and Descriptor clusters on ESP32 Change-Id: I37b61425a55d8210c2286becce47917fddf54a3f Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1418359 Reviewed-by: Rob Oliver <[email protected]> Reviewed-by: Kevin Cheung <[email protected]> Reviewed-by: Jerry Lee <[email protected]> * new: added stub file. Included callbacks for successful operation of lock/unlock commands Change-Id: I9f4d601feb3b043d3c6689775bcaf40a8c5564d2 Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1420959 Reviewed-by: Michael Spang <[email protected]> Reviewed-by: Jerry Lee <[email protected]> * Enable PW RPC server on chef-built virtual device app Change-Id: I878955e9df26e893c136650654019a8fa14e2a8b Reviewed-on: https://team-review.git.corp.google.com/c/npe-tse-chip-sdk/third_party/connectedhomeip/+/1417979 Reviewed-by: Doug Ferraz <[email protected]> * cosmetic change Change-Id: Ia2063a395a8d3f16965356d4a76b0d9df0834e57 * changes to linux pigweed dependencies. Still has issues building Pigweed Change-Id: I2be4e81f6c2e14112e31a0803813ef56d012b206 * Restyled by gn * Restyled by autopep8 * Restyled by gn Co-authored-by: Sebastian Mauer <[email protected]> Co-authored-by: MT Tsai <[email protected]> Co-authored-by: vinitg1 <[email protected]> Co-authored-by: Restyled.io <[email protected]> Change-Id: I827aa39ea41b8084d6fdca202e5a87e0f29cb4f3 * fix: added initialization to platform wifi network commissioning instance (project-chip#17983) Change-Id: I03b6b523d4c4557ab6cc432216e48b6d6b2b6964 * Chef - Revert changes on lighting-app that separate wifi and thread Co-authored-by: Douglas Rocha Ferraz <[email protected]> Co-authored-by: Sebastian Mauer <[email protected]> Co-authored-by: MT Tsai <[email protected]> Co-authored-by: vinitg1 <[email protected]> Co-authored-by: Restyled.io <[email protected]> * Support to return software_version_string with <branch>:<commit_id> on linux platform (project-chip#19710) * Chef - Add 13 sample apps (project-chip#19663) * Chef - Remove redundant hash_string in sample_app_util rename func * Chef - Add debugg output on exception to stateful_shell * Chef - Add choices for device arg * Chef - Add 13 sample apps * Revert "Support to return software_version_string with <branch>:<commit_id> on linux platform (project-chip#19710)" (project-chip#19786) This reverts commit 8da6fc8. * Truncate the branch info of the software version string while the total length greater equal to 64 bytes. (project-chip#19788) Make the filling of software version string with <branch>:<commit_id> as an option. The new option for it is '-a' or '--automated_test_stamp'. * Make Chef CI use existing zzz_generated and complete Chef CD for existing platforms (project-chip#19478) * Squashed commit of the following: commit b5d5920 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 18:17:34 2022 +0000 [no ci] comment commit 7c5fb08 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 18:15:37 2022 +0000 [no ci] Make border nice commit d67a7bc Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 18:09:29 2022 +0000 [no ci] restyle commit 5783829 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 17:48:39 2022 +0000 Add error handling to build all commit 083b072 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 17:15:33 2022 +0000 [no ci] update build image version commit 48805a8 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 08:20:49 2022 +0000 [no ci] minor commit 3cae95c Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 08:15:22 2022 +0000 [no ci] Minor commit df929b2 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 07:37:49 2022 +0000 Minor commit 759ddb0 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 07:28:36 2022 +0000 Minor commit d9ca2a6 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 07:22:03 2022 +0000 Style commit dbb9b30 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 06:50:11 2022 +0000 Style commit 3daff46 Author: Austin Bozowski <[email protected]> Date: Fri Jun 10 02:58:43 2022 +0000 nrf bundle commit 7d38eb4 Author: Austin Bozowski <[email protected]> Date: Wed Jun 8 16:34:57 2022 +0000 Linux bundle commit fd5689e Author: Austin Bozowski <[email protected]> Date: Wed Jun 8 09:08:42 2022 +0000 Make esp32 generic commit 1af3a2e Author: Austin Bozowski <[email protected]> Date: Tue Jun 7 08:35:52 2022 +0000 Missed comment commit 5f7c41c Author: Austin Bozowski <[email protected]> Date: Tue Jun 7 08:32:07 2022 +0000 Example bundle function * Bundle .matter, metadata & ensure .matter commit * Add partial check for .matter regen * Restyle and spelling * Address comments * Remove reflection * Generate zzz, .MATTERMD5 should go away in future * Temp del workflows * Remove chef exclusion from regen * Make regen all put chef exs in individual dirs * Remove validate zzz * Remove unused code from chef, change use_zzz * Skip util test files in gen all * Commit chef in root zzz * Delete chef zzz * Clean chef .matter files * Add post build for chef * Change .matter bundle rc to oot zzz * Generated files * Restore workflows * Change open to with * Restyle * Chef - Fix broken esp32 RPC build caused by project-chip#18621 (project-chip#19876) * Chef - Fix broken esp32 RPC build caused by project-chip#18621 * Chef - Fix esp32 RPC build issue caused by pigweed update * Make Scenes name support dependent on FeatureMap attribute (project-chip#18667) * Make Scenes name support dependent on FeatureMap attribute * Fix CI * Rebuild Zap generated files * Fix CI for ipv6only/esp32 example build * Fix errors regarding ownership of repo. (Taken from project-chip#18302) * Bump chef.yaml platform containers to 0.5.75 Co-authored-by: rgoliver <[email protected]> Co-authored-by: Douglas Rocha Ferraz <[email protected]> Co-authored-by: Sebastian Mauer <[email protected]> Co-authored-by: MT Tsai <[email protected]> Co-authored-by: vinitg1 <[email protected]> Co-authored-by: Restyled.io <[email protected]> Co-authored-by: MtTsai <[email protected]> Co-authored-by: Michael Spang <[email protected]> Co-authored-by: Austin Bozowski <[email protected]> Co-authored-by: Jean-Francois Penven <[email protected]>
Problem
Change overview
From a high level the main changes here are:
zap_regen_all
Testing